Deprecated 'network', introduce 'network_interface'

[sparkprime]

This addresses #609 and #509. The old network { } block is deprecated by this PR. Here is how to rewrite configs:

network {
    source = "foo"
}

becomes

network_interface {
    network = "foo"
    access_config {
    }
}


network {
    source = "foo"
    external_address = "blah"
}

becomes

network_interface {
    network = "foo"
    access_config {
        ip_nat = "blah"
    }
}

Finally, the following is now possible (to avoid any external address).

network_interface {
    network = "foo"
}

I am unsure how to deprecate attributes within the code. Is there a precedent for that? Shall I just print to stderr from inside the provider?

thanks

[phinze]

Is there a precedent for that? Shall I just print to stderr from inside the provider?

There is no precedent for this, so I think printing to stderr works AOK here.

[sparkprime]

I wonder where to print it? Create/Update will only get called if the user actually changes it / makes new resources which is not what we want. We want it to print a message if the config contains a matching resource, even if that resource is not changed.

[phinze]

Eh dang you're right. Probably need schema/helper support for this.

[sparkprime]

It looks like it's not even possible to use stdout/stderr from a provider. I suggest just applying this for now (people are waiting on it) and we'll have to figure out how to do deprecation warnings before the next release.

[phinze]

Ok that sounds reasonable. Sprouted #957 to track the deprecation support.

[phinze]

LGTM! Merging

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.