Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Support provisioner hooking #2044

Closed
fgrehm opened this issue Aug 12, 2013 · 2 comments
Closed

Proposal: Support provisioner hooking #2044

fgrehm opened this issue Aug 12, 2013 · 2 comments
Labels
enhancement

Comments

@fgrehm
Copy link
Contributor

fgrehm commented Aug 12, 2013

On vagrant-cachier we need to run some code around provisioners execution and we had to monkey patch the builtin provision action to achieve that. Maybe we could implement something similar to Vagrant::Environment#hook from within Vagrant::Action::Builtin::Provision#run_provisioner

I'm wondering if it would make sense to add support for hooking into provisioners runs on vagrant itself but I just don't know if there are other use cases for doing this (and it is reason why this is not a Pull Request :P)
@fgrehm
Copy link
Contributor Author

fgrehm commented Oct 18, 2013

For the record: I've started some work on this on https://github.com/fgrehm/vagrant/tree/2044-provisioner-hooking and will do some testing on vagrant-cachier to see how it goes

@fgrehm fgrehm mentioned this issue Oct 21, 2013
Merged
@mitchellh
Copy link
Contributor

Fixed by #2405

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitchellh @fgrehm