Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: helm cli version 3.2.0 is failing in vault-helm-test during bats unit test #539

Closed
anapsix opened this issue May 28, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@anapsix
Copy link

anapsix commented May 28, 2021

Description of the bug
In CircleCI, vault-helm-test image used for test-unit (bats /helm-test/test/unit) is using bugged version of Helm CLI client (v3.2.0) failling to render a valid templates. The same templates are passing bats unit tests and are rendering just fine using Helm CLI version v3.6.0.
Based on my tests going through every version of Helm CLI from 3.2.0 and up, the rendering issue is fixed in v3.5.0

Test Image:

To Reproduce
Steps to reproduce the behavior:

  1. Clone my fork and switch to allow-templated-extracontainers branch (related to process extraInitContainers and extraContainers with tpl #536)
    git clone git@github.com:anapsix/vault-helm.git anapsix-vault-helm
    cd anapsix-vault-helm
    git checkout allow-templated-extracontainers
  2. Pull the image CI is using for bats unit tests
    docker pull docker.mirror.hashicorp.services/hashicorpdev/vault-helm-test:0.1.0
  3. Run bats unit test
    docker run \
      -it \
      --rm \
      -v "${PWD}:/src" \
      -w /src \
      docker.mirror.hashicorp.services/hashicorpdev/vault-helm-test:0.1.0 \
      bash -c 'helm version; bats /src/test/unit/server-statefulset.bats'
  4. Observe the failure
  5. Try again with new version of Helm
    docker run \
      -it \
      --rm \
      -v "${PWD}:/src" \
      -w /src \
      docker.mirror.hashicorp.services/hashicorpdev/vault-helm-test:0.1.0 \
      bash -c 'wget -O- https://get.helm.sh/helm-v3.6.0-linux-amd64.tar.gz | tar -xzC /usr/local/bin --strip-components 1 linux-amd64/helm; helm version; bats /src/test/unit/server-statefulset.bats'

Please upgrade Helm version in vault-helm-test images used by CI to more recent version.

@tvoran
Copy link
Member

tvoran commented Jun 5, 2021

Fixed by #543

@tvoran tvoran closed this as completed Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants