Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sleep in the preStop lifecycle step #188

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Adding sleep in the preStop lifecycle step #188

merged 1 commit into from
Jan 30, 2020

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Jan 30, 2020

Aims to make vault pod termination more graceful with respect to user
requests.

Resolves #125

Aims to make vault pod termination more graceful with respect to user
requests.
@jasonodonnell jasonodonnell self-requested a review January 30, 2020 07:23
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tvoran tvoran added this to the v0.4.0 milestone Jan 30, 2020
@tvoran tvoran merged commit 45c9118 into master Jan 30, 2020
@tvoran tvoran deleted the sleep-prestop branch January 30, 2020 17:39
radudd pushed a commit to radudd/vault-helm that referenced this pull request Jun 5, 2020
Aims to make vault pod termination more graceful with respect to user
requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add sleep to preStop lifecycle
2 participants