Add an option to set annotations on the StatefulSet #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @cablespaghetti, this looks useful! Can you add unit test coverage for this feature? You can find them in |
|
@jasonodonnell Sorry it took a while. Have some tests. 👍 |
|
@jasonodonnell Don't forget about this one :) |
tvoran
requested changes
May 1, 2020
|
Bump on this @cablespaghetti |
|
Bump @cablespaghetti :) |
Signed-off-by: Sam Weston <weston.sam@gmail.com>
Signed-off-by: Sam Weston <weston.sam@gmail.com>
Signed-off-by: Sam Weston <weston.sam@gmail.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
|
@tvoran @jasonodonnell I've committed the requested changes now. Sorry for the delay. |
tvoran
approved these changes
Aug 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this to add the annotation for Reloader to the StatefulSet. I've tried to follow the conventions currently used by the chart but let me know if anything needs changing.