Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable failurePolicy for injector's webhook #400

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

orirawlings
Copy link
Contributor

Fixes #399

@orirawlings
Copy link
Contributor Author

I didn't notice #384 when I first opened this, so this might be a duplicate.

Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@jasonodonnell jasonodonnell merged commit 5eb0ba5 into hashicorp:master Oct 13, 2020
@jasonodonnell jasonodonnell mentioned this pull request Oct 20, 2020
@orirawlings orirawlings deleted the failurePolicy branch December 4, 2020 16:10
@orirawlings orirawlings mentioned this pull request Dec 14, 2020
# To block pod creation while webhook is unavailable, set the policy to `Fail` below.
# See https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#failure-policy
#
# failurePolcy: Fail
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a typo in the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable failurePolicy for the MutatingWebhook of the vault agent injector
3 participants