Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Support configuring various properties as YAML directly. #565

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Jul 6, 2021

Supported properties include: pod toleration, pod affinity, and node selectors.

Supported properties include: pod tolerations, pod affinity, and node selectors.
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 6, 2021

CLA assistant check
All committers have signed the CLA.

@benashz benashz requested review from tomhjp and tvoran July 6, 2021 20:29
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a few questions.

values.schema.json Show resolved Hide resolved
templates/_helpers.tpl Outdated Show resolved Hide resolved
templates/_helpers.tpl Outdated Show resolved Hide resolved
templates/_helpers.tpl Outdated Show resolved Hide resolved
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small suggestion.

templates/_helpers.tpl Outdated Show resolved Hide resolved
@benashz benashz merged commit 1e4709c into master Jul 7, 2021
@benashz benashz deleted the benashz/vault-498-yaml-props branch July 9, 2021 15:16
@tvoran tvoran mentioned this pull request Jul 28, 2021
illegalnumbers pushed a commit to streamnative/vault-helm that referenced this pull request Mar 17, 2022
…shicorp#565)

* feature: Support configuring various properties as YAML directly.
Supported properties include: pod tolerations, pod affinity, and node selectors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants