Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI: some PKI unauthed endpoints aren't being marked as such #19581

Closed
cipherboy opened this issue Mar 16, 2023 · 0 comments · Fixed by #19600
Closed

OpenAPI: some PKI unauthed endpoints aren't being marked as such #19581

cipherboy opened this issue Mar 16, 2023 · 0 comments · Fixed by #19600
Assignees
Labels
bug Used to indicate a potential bug core/openapi devex Developer Experience

Comments

@cipherboy
Copy link
Contributor

Describe the bug

Some OpenAPI endpoints for PKI aren't being marked as such:

OpenAPI data: map[description:Fetch an issuer's Certificate Revocation Log (CRL). get:map[operationId:getPkiIssuerIssuer_refCrl responses:map[200:map[content:map[application/json:map[schema:map[$ref:#/components/schemas/PkiIssuerCrlResponse]]] description:OK]] tags:[secrets]] parameters:[map[description:Reference to a existing issuer; either "default" for the configured default issuer, an identifier or the name assigned to the issuer. in:path name:issuer_ref required:true schema:map[default:default type:string]]]]
Unauthed endpoint is not marked unauthenticated in OpenAPI data: /pki/issuer/{issuer_ref}/crl/delta/pem->issuer/default/crl/delta/pem

To Reproduce
Steps to reproduce the behavior:

  1. Run vault secrets enable pki
  2. Run vault read sys/internal/specs/openapi
  3. See error: some PKI endpoints aren't marked unauthed.

Expected behavior

PKI endpoints which are unauthed should be marked with x-vault-unauthenticated per our OpenAPI spec :-)

Environment:

main

cc: @averche :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug core/openapi devex Developer Experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants