Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for docker buildx configuration? #240

Closed
danny-huang-openfind opened this issue May 4, 2023 · 1 comment
Closed

Support for docker buildx configuration? #240

danny-huang-openfind opened this issue May 4, 2023 · 1 comment

Comments

@danny-huang-openfind
Copy link

Just a quick ask, is this extension support to the format of which docker buildx's configuration is using?
https://docs.docker.com/build/bake/configuring-build/

Since this extension looks like the most popular extension for HCL files on vscode, I hope it can support to buildx.

@radeksimko
Copy link
Member

radeksimko commented May 4, 2023

Hi @danny-huang-openfind
As long as the files are suffixed with *.hcl - and, obviously, the language is HCL-based - which seems to be the case for the Docker Bake build files, then it's supported.

It's worth noting though that the features this extension provides are more limited compared to what you might expect. It provides primarily static syntax highlighting and nothing else and the limited feature set is mostly intentional.

We might add some product-agnostic formatting as per #98

The reasoning behind it is the difference between languages built on HCL (such as Terraform, Packer, Nomad, Docker Bake and others) which you can read more about at https://github.com/hashicorp/syntax#hcl-vs-terraform--packer--

Features like completion, hover, go-to-definition etc. only make sense for the languages built on top of HCL, rather than HCL itself. It is therefore expected that these would be implemented as part of dedicated VS Code extensions, hence we maintain the Terraform extension intentionally separately. So applying the same logic, someone could build an extension dedicated to Docker Bake which provides those features. We do not intend to do that ourselves but we plan to maintain some libraries to help with that and make it easier to do so. Some early efforts are in https://github.com/hashicorp/hcl-lang and https://github.com/hashicorp/syntax

I hope that helps answer your question.

@radeksimko radeksimko closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants