Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to (local) module implementation from source #669

Closed
radeksimko opened this issue Jun 18, 2021 · 3 comments
Closed

Go to (local) module implementation from source #669

radeksimko opened this issue Jun 18, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request modules Functionality related to the module block and modules generally terraform-ls Features/bugs which will be implemented/fixed purely on the LS side
Milestone

Comments

@radeksimko
Copy link
Member

radeksimko commented Jun 18, 2021

Problem Statement

When users edit local modules they might benefit from being able to jump between those modules from a place where they're called to the source code.

For example in a configuration like this

module "example" {
  source = "./foo-submodule" 
}

It should be easy to open ./foo-submodule in the editor.

User Impact

Any users which use local modules would benefit.

Expected User Experience

Go To Definition

https://code.visualstudio.com/docs/editor/editingevolved#_go-to-definition

ctrlhover

Proposal

Blocking Question

Explore the UX implications of "Go To Declaration" also and see if that can/should be implemented too.

@radeksimko radeksimko added the enhancement New feature or request label Jun 18, 2021
@radeksimko radeksimko changed the title Link to local module implementation from source Go to (local) module implementation from source Jun 18, 2021
@radeksimko radeksimko added the terraform-ls Features/bugs which will be implemented/fixed purely on the LS side label Jun 18, 2021
@danieldreier danieldreier added the modules Functionality related to the module block and modules generally label Jul 23, 2021
@dbanck dbanck self-assigned this Mar 24, 2022
@dbanck
Copy link
Member

dbanck commented Apr 6, 2022

Resolved via hashicorp/terraform-ls#558 and will be included in the 0.27.0 language server release.

@dbanck dbanck closed this as completed Apr 6, 2022
@dbanck dbanck reopened this Apr 6, 2022
@dbanck dbanck added this to the v2.22.0 milestone Apr 6, 2022
@jpogran
Copy link
Contributor

jpogran commented Apr 14, 2022

Closing as 0.27.0 is being released.

@jpogran jpogran closed this as completed Apr 14, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request modules Functionality related to the module block and modules generally terraform-ls Features/bugs which will be implemented/fixed purely on the LS side
Projects
None yet
Development

No branches or pull requests

4 participants