Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Color syntax: add scope for resource_type and resource_name #710

Closed
tringuyen-yw opened this issue Aug 1, 2021 · 3 comments · Fixed by #934
Closed
Assignees
Labels
enhancement New feature or request syntax

Comments

@tringuyen-yw
Copy link

tringuyen-yw commented Aug 1, 2021

Using VSCode Version: 1.58.2, OS: Linux x64 5.8.0-63-generic snap (Ubuntu 20.04.2)

Currently a resource type and resource identification are recognized as string. As such the color syntax is not very readable. Can you please add new editor scopes for:

  • Terraform resource_type
  • Terraform resource_name

To allow to configure the corresponding element with a different color syntax. The attached screenshot shows the desired effects using IntelliJ IDEA v2021.2

VS Code Color theme:

VSCode_Terraform_colorSyntax_resource

@radeksimko radeksimko added enhancement New feature or request syntax labels Aug 2, 2021
@softveda
Copy link

softveda commented Aug 2, 2021

I like this too.

@tringuyen-yw tringuyen-yw changed the title [Feature request] Color syntax: add scope for resource_type and resource_identification [Feature request] Color syntax: add scope for resource_type and resource_name Aug 2, 2021
@jpogran jpogran self-assigned this Feb 11, 2022
@radeksimko
Copy link
Member

radeksimko commented Feb 23, 2022

Hi folks,
While #934, hashicorp/terraform-ls#802 and made it possible to distinguish between plain strings and labels I just wanted to note that we plan to still look into the original proposal - that is distinguishing between the resource type and name.

We track that under hashicorp/terraform-ls#803 as most of the relevant work will be done on the language server.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request syntax
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants