Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically refresh Terraform Module Calls View #1088

Merged
merged 5 commits into from
May 9, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Apr 29, 2022

This commit automatically refreshes the Terraform Module Calls View when providers change in open document.

This introduces a StaticFeature which registers a handler for the client.refreshModuleCalls request which terraform-ls can call to refresh the data shown in the Terraform Module Calls view. The terraform-ls server was modified to send client.refreshModuleCalls requests in hashicorp/terraform-ls#909

@jpogran jpogran added this to the 2.23.0 milestone Apr 29, 2022
@jpogran jpogran added the enhancement New feature or request label Apr 29, 2022
@jpogran jpogran self-assigned this Apr 29, 2022
@jpogran jpogran force-pushed the gh-722-refresh-module-calls branch 2 times, most recently from f385b32 to 6e17aff Compare May 4, 2022 13:40
This commit automatically refreshes the Terraform Module Calls View when providers change in open document.

This introduces a StaticFeature which registers a handler for the `client.refreshModuleCalls` request which terraform-ls can call to refresh the data shown in the Terraform Module Calls view. The terraform-ls server was modified to send `client.refreshModuleCalls` requests in hashicorp/terraform-ls#902
@jpogran jpogran marked this pull request as ready for review May 4, 2022 14:54
@jpogran jpogran requested a review from a team as a code owner May 4, 2022 14:54
src/features/types.ts Outdated Show resolved Hide resolved
src/features/moduleCalls.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
jpogran and others added 4 commits May 4, 2022 11:29
Co-authored-by: Radek Simko <radek.simko@gmail.com>
Co-authored-by: Radek Simko <radek.simko@gmail.com>
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jpogran jpogran merged commit 3c3eedc into main May 9, 2022
@jpogran jpogran deleted the gh-722-refresh-module-calls branch May 9, 2022 16:33
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants