Introduce a new setting for enhanced validation #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Adds `terraform.validation.earlyValidation` setting to the initializationOptions sent to terraform-ls. I chose to use `terraform.validation` as we expect to add future settings for this feature. This relies on functionality to be added to terraform-ls to parse the new setting.
jpogran
force-pushed
the
early_validation_setting
branch
from
245dcea to
222ad7f
Compare
This was referenced Oct 2, 2023
radeksimko
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
👍🏻 Working as expected, assuming hashicorp/terraform-ls#1436 is merged
|
Regarding documentation I expect we can address that in a separate PR, either by reusing something from hashicorp/terraform-ls#1433 or linking to it. |
radeksimko
reviewed
Oct 2, 2023
Co-authored-by: Radek Simko <radek.simko@gmail.com>
radeksimko
changed the title
radeksimko
approved these changes
Oct 3, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
terraform.validation.enableEnhancedValidationsetting to the initializationOptions sent to terraform-ls.I chose to use
terraform.validationas we expect to add future settings for this feature.This relies on functionality to be added to terraform-ls to parse the new setting.