Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump js-releases to 1.7.0 #1563

Merged
merged 1 commit into from
Sep 13, 2023
Merged

deps: Bump js-releases to 1.7.0 #1563

merged 1 commit into from
Sep 13, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Sep 11, 2023

This also updates a transitive dependency openpgp to 5.10.1, which should in turn address GHSA-ch3c-v47x-4pgp

While this was flagged as security alert my understanding is that it doesn't impact us (or our users) in any way, because js-releases does not use readCleartextMessage nor verifyCleartextMessage as per https://github.com/hashicorp/js-releases/blob/6b64ff2a17be14820d7cdef5fad8d45645e83a80/src/index.ts#L215-L231

@radeksimko radeksimko added the dependencies Auto-pinning label Sep 11, 2023
@radeksimko radeksimko requested a review from a team as a code owner September 11, 2023 09:48
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it shouldn't affect users, because we use js-releases at build time to bundle the language server and don't ship it with the final extension.

@dbanck
Copy link
Member

dbanck commented Sep 11, 2023

The test failure is strange, though

@dbanck dbanck force-pushed the deps-bump-js-releases branch from 915f8f6 to ad54cad Compare September 13, 2023 10:11
@dbanck dbanck merged commit 4937e49 into main Sep 13, 2023
17 checks passed
@dbanck dbanck deleted the deps-bump-js-releases branch September 13, 2023 10:16
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants