Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Terraform: Apply" command #700

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add "Terraform: Apply" command #700

wants to merge 1 commit into from

Conversation

kamilturek
Copy link

Closes #648.

Command terraform.apply is already registered so this PR only adds it to extension manifest.

vscode.commands.registerCommand('terraform.apply', async () => {
await terraformCommand('apply', false, clientHandler);
}),

image

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 22, 2021

CLA assistant check
All committers have signed the CLA.

@kamilturek kamilturek changed the title Create command contribution for terraform apply Add "Terraform: Apply" command Jul 22, 2021
@jpogran
Copy link
Contributor

jpogran commented Sep 23, 2021

Thanks @kamilturek for the contribution! Apologies on the delay in response, but we appreciate the help.

The reason we haven't surfaced the existing terraform apply command yet is that it will open the current terminal and just paste the command there. We haven't decided on the best UX here yet. If we enable it as is, it won't know if the command succeeded or failed, if terraform was on the path or not, if it was in the correct folder, etc.

What are your thoughts on this? While we discuss, I'm going to mark this as draft and put it on our planning board.

@jpogran jpogran marked this pull request as draft September 23, 2021 15:23
@jpogran jpogran added the enhancement New feature or request label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Terraform: Apply as a command
3 participants