Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal sdist does not perform all checks. #652

Closed
bos opened this issue May 24, 2012 · 4 comments
Closed

cabal sdist does not perform all checks. #652

bos opened this issue May 24, 2012 · 4 comments
Labels
Cabal: cmd/sdist cabal-install: cmd/check old-milestone: ⊥ Moved from https://github.com/haskell/cabal/milestone/5 type: bug
Milestone

Comments

@bos
Copy link
Contributor

bos commented May 24, 2012

(Imported from Trac #660, reported by @kmcallister on 2010-04-11)

Some checks in Distribution.PackageDescription.Check are defined on GenericPackageDescription and are called via checkPackage. checkPackage is called by configure, which ignores dist-related checks, but not by sdist, which only calls checkConfiguredPackage.

So any dist-related checks on GenericPackageDescription, e.g. warning of base version not bounded above, will have no effect.

@bos
Copy link
Contributor Author

bos commented May 24, 2012

(Imported comment by @kmcallister on 2010-04-11)

Should revisit #395 when this is fixed.

@bos
Copy link
Contributor Author

bos commented May 24, 2012

(Imported comment by @dcoutts on 2010-04-11)

This will involve changing the public UserHooks API since the sDistHook uses PackageDescription rather than GenericPackageDescription.

@ttuegel ttuegel added this to the _|_ milestone Apr 23, 2015
@gbaz gbaz changed the title dist checks defined on GenericPackageDescription are inert cabal sdist does not perform all checks. Feb 7, 2018
@gbaz
Copy link
Collaborator

gbaz commented Feb 7, 2018

Since cabal check does run all checks, these checks aren't really "inert". However, it is still irritating that sdist only does a partial check. It would be nice to fix this.

@ffaf1 ffaf1 mentioned this issue Feb 17, 2023
4 tasks
@andreabedini andreabedini added the old-milestone: ⊥ Moved from https://github.com/haskell/cabal/milestone/5 label Oct 17, 2023
@ffaf1
Copy link
Collaborator

ffaf1 commented Nov 16, 2023

Closed via #8427

@ffaf1 ffaf1 closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cabal: cmd/sdist cabal-install: cmd/check old-milestone: ⊥ Moved from https://github.com/haskell/cabal/milestone/5 type: bug
Projects
None yet
Development

No branches or pull requests

6 participants