-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mergify and actions upgrades #10260
Mergify and actions upgrades #10260
Conversation
09e4a83
to
bca9211
Compare
I did a quick audit of the other actions we use in our workflows; it looks like only |
BTW, the summary still complains about the configuration. This is because it uses the Mergify configuration on |
Mergify is requiring that separate queues be used for different merge strategies, staerting in mid-September with a brownout in mid-August. https://docs.mergify.com/configuration/file-format/#queue-rules
bca9211
to
bcaa508
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Some unfortunate repetition with Mikolaj but that's not an issue: we can't have too much @Mikolaj!!!
Sadly, while there is a |
This one wasn't throwing warnings, but has also been updated with the same deprecation timeframe. It's also incompatible with actions/upload-artifact@v4.
9b13595
to
c7ac80c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least we have a competent bot! :D
* implement mergify rules for release branches We only handled the case of backports previously, but the current release checklist expects that we can commit PRs to release branches during a release (e.g. changelogs, because we want the list of changelog.d files that are actually part of the release). * block merging if PR has a 'blocked:' label * update backports strategy for #10260 --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@mergify backport 3.12 |
✅ Backports have been created
|
* upgrade actions/upload-artifact to v4 * update Mergify queue strategies Mergify is requiring that separate queues be used for different merge strategies, staerting in mid-September with a brownout in mid-August. https://docs.mergify.com/configuration/file-format/#queue-rules * update actions/download-artifact This one wasn't throwing warnings, but has also been updated with the same deprecation timeframe. It's also incompatible with actions/upload-artifact@v4. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 75711fc) # Conflicts: # .github/mergify.yml # .github/workflows/validate.yml
* upgrade actions/upload-artifact to v4 * update Mergify queue strategies Mergify is requiring that separate queues be used for different merge strategies, staerting in mid-September with a brownout in mid-August. https://docs.mergify.com/configuration/file-format/#queue-rules * update actions/download-artifact This one wasn't throwing warnings, but has also been updated with the same deprecation timeframe. It's also incompatible with actions/upload-artifact@v4. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 75711fc)
* upgrade actions/upload-artifact to v4 * update Mergify queue strategies Mergify is requiring that separate queues be used for different merge strategies, staerting in mid-September with a brownout in mid-August. https://docs.mergify.com/configuration/file-format/#queue-rules * update actions/download-artifact This one wasn't throwing warnings, but has also been updated with the same deprecation timeframe. It's also incompatible with actions/upload-artifact@v4. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 75711fc)
* upgrade actions/upload-artifact to v4 * update Mergify queue strategies Mergify is requiring that separate queues be used for different merge strategies, staerting in mid-September with a brownout in mid-August. https://docs.mergify.com/configuration/file-format/#queue-rules * update actions/download-artifact This one wasn't throwing warnings, but has also been updated with the same deprecation timeframe. It's also incompatible with actions/upload-artifact@v4. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 75711fc)
* upgrade actions/upload-artifact to v4 * update Mergify queue strategies Mergify is requiring that separate queues be used for different merge strategies, staerting in mid-September with a brownout in mid-August. https://docs.mergify.com/configuration/file-format/#queue-rules * update actions/download-artifact This one wasn't throwing warnings, but has also been updated with the same deprecation timeframe. It's also incompatible with actions/upload-artifact@v4. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 75711fc)
Mergify and actions upgrades (backport #10260)
Mergify is requiring different queues for different merge strategies as of mid-September.
actions/upload-artifact@v3
andactions/download-artifact@v3
are being removed in November.Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: