Make --enable-documentation work for non-local packages
#4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch non-local packages would receive all their configuration like this: ``` perpkg = maybe mempty f (Map.lookup (packageName pkg) perPackageConfig) ``` If there is no explicit configuration for a package the default `mempty` is used. We add `projectConfigNonLocalPackages` field to `ProjectConfig`. `projectConfigNonLocalPackages` reflects cabals global configuration. Instead of falling back back to `mempty` directly we lookup up the desigured configuration in this new field.
|
@alexbiehl There are some legit-looking failures, though, can you look into them? |
4 tasks
1 task
|
This has been addressed in c094940. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before non-local packages would receive all their configuration like this:
If there is no explicit configuration for a package the default
memptyis used.We add
projectConfigNonLocalPackages :: PackageConfigfield toProjectConfig.projectConfigNonLocalPackagesreflects cabals global configuration. Instead of falling back back tomemptydirectly we lookup up the desigured configuration in this new field.projectConfigNonLocalPackagesis the same asprojectConfigLocalPackages. We need to sort out what we want here.documentation: Truedoes not work yet. But it will once we sort out cli defaults override new-build cabal.project settings #4737Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!