Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new-install symlink location #5188

Merged
merged 3 commits into from
Mar 6, 2018
Merged

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Mar 5, 2018

Now new-install(-nonlocal-exes) should work without issues (if the ~/.cabal/config was generated with this)

Closes #5000 (yay!)

@23Skidoo can we cherry-pick it on 2.2 too?

Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@fgaz fgaz added this to the 2.2 milestone Mar 5, 2018
@23Skidoo
Copy link
Member

23Skidoo commented Mar 5, 2018

Sure, if it's new-build only, then it's low-risk.

@fgaz
Copy link
Member Author

fgaz commented Mar 5, 2018

Yup. new-build and I set symlink-bindir (which is only used by new-install despite being there for literally 10 years) to ~/.cabal/bin by default in ~/.cabal/config

@hvr
Copy link
Member

hvr commented Mar 5, 2018

I don't give up hope on #680 ... maybe for 3.0? :-)

fgaz added 3 commits March 6, 2018 08:21
It is set to the same directory used by the old cabal install command,
ie `~/.cabal/bin` on linux, as it will be used to "install" (symlink)
executables by new-install.
Before there wasn't much feedback. Most times the only thing that got
printed was "Up to date".
@fgaz fgaz force-pushed the symlinkbindir-config branch from be062a7 to 5e106be Compare March 6, 2018 08:22
@fgaz
Copy link
Member Author

fgaz commented Mar 6, 2018

Merging this now for the same reason as #4825
(travis was green. I stopped it because i forgot [ci skip] when force pushing the changelog)

@fgaz fgaz merged commit b394997 into haskell:master Mar 6, 2018
@fgaz
Copy link
Member Author

fgaz commented Mar 6, 2018

@23Skidoo fyi I just pushed it on 2.2 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants