-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message for empty --allow-newer= (fix #7740) #8140
Improve error message for empty --allow-newer= (fix #7740) #8140
Conversation
04aaf81
to
838c360
Compare
Okay, I think it's ready for review now. I found a way to extend the current approach for converting
I didn't notice that error message were tested anyhow. Have I missed it and should add a test? At the moment I'm not sure where to add it. |
Would appreciate if @phadej could take a look, as the parts of code I touched are mostly due to him. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A tiny changelog file would be needed nevertheless. LGTM otherwise. Congrats.
838c360
to
299893c
Compare
@Mikolaj done! Thanks for the review! |
4252c7e
to
a761d85
Compare
CI got canceled. Let me try to restart. |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
a761d85
to
b8c67bb
Compare
No time to lose --- let's merge it (via merge_me label) before somebody says it doesn't make sense. |
Jetzt geht's los! |
This is a WIP, it's not beautiful:(see the first comment below)Should
"parsecToReadE"
be removed? It can be but this may make it harder to debug anything that goes viaparsecToReadE
.expecting "*"
is annoying but I'm not sure how to remove it either.Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!