improve install target handling logic #8498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gbaz: could you rebase (there seem to be a conflict)? |
Kleidukos
approved these changes
Dec 24, 2022
andreasabel
approved these changes
Jan 2, 2023
andreasabel
added
squash+merge me
mergify
bot
added
the
merge delay passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8325 and resolves #8094.
cabal install pkg-x.y.zfails unless--ignore-projectis given #8325cabal v2-install --ignore-projectcrashes when project file is present #8094The latter issue was just a typo. The former issue is subtle and has to do with using "--ignore-project" to differentiate between when we want to parse "foo:bar" as a uri vs. a target selector.
Note that I think this is a strict improvement but still pretty weird. I also added a few comments to help explain what's going on.