Implement Seq folds as coerced FingerTree folds #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
meooow25
commented
Nov 30, 2024
meooow25
commented
- foldr1 and foldl1 are now implemented as coercions.
- Other folds were implemented using coercions in a complicated manner, which is now simplified. GHC is smart enough to compile these to the same Core, so there is no change in runtime behavior.
* foldr1 and foldl1 are now implemented as coercions. * Other folds were implemented using coercions in a complicated manner, which is now simplified. GHC is smart enough to compile these to the same Core, so there is no change in runtime behavior.
treeowl
reviewed
Nov 30, 2024
| foldMap f = foldMap (f .# getElem) .# getSeq | ||
| foldr f z = foldr (f .# getElem) z .# getSeq | ||
| foldl f z = foldl (f .^# getElem) z .# getSeq | ||
| #ifdef __GLASGOW_HASKELL__ |
There was a problem hiding this comment.
We need foldMap for other implementations too.
There was a problem hiding this comment.
What do you mean? We have foldMap implementations.
There was a problem hiding this comment.
Am I missing something? It looks like you just hid it behind an ifdef.
There was a problem hiding this comment.
Oh, you mean Haskell implementations, I misunderstood. Those definitions are in the #else part of this #ifdef.
There was a problem hiding this comment.
Does it seem fine, @treeowl?
|
Looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.