Improve {Set,Map}.fromAscList and friends #963
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #949 (comment)
This PR is based off #962, so marking as draft.
This PR improves
Set.fromAscList
,Set.fromDescList
Map.fromAscList
,Map.fromDescList
,Map.fromAscListWith
,Map.fromDescListWith
,Map.fromAscListWithKey
,Map.fromDescListWithKey
by making the combine function they use a good consumer and producer in terms of fusion. This gets rid of the intermediate list always created today, and also fuses with the input list if possible.
Benchmarks on GHC 9.2.5:
Before
After
Some observations:
fromDescList:fusion
improves but not as much asfromAscList:fusion
. The cause seems be that fusion with[n,n-1..1]
does not work out as well as[1..n]
, but I don't know why and didn't dig into it much.