Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rename function without directory/file distinction #58

Closed
agentm opened this issue Jul 12, 2016 · 2 comments
Closed

add rename function without directory/file distinction #58

agentm opened this issue Jul 12, 2016 · 2 comments
Assignees
Labels
type: a-feature-request This is a request for a new feature.
Milestone

Comments

@agentm
Copy link

agentm commented Jul 12, 2016

On both Windows and Posix platforms, the invocation of the underlying rename function is identical, so the value of explicitly choosing either the directory or file API is diminished. In my specific use case, I wanted to implement renameSync but had to swipe the System.Directory's implementation instead of being able to rely on the System.Directory module.

In addition, checking for a file or directory in advance opens a potential race condition and blocks usage of rename against non-file, non-directory nodes such as devices.

For my use case, a rename function which ignores the directory/file distinction would have solved the problem.

@Rufflewind Rufflewind added the type: a-feature-request This is a request for a new feature. label Jul 14, 2016
@Rufflewind
Copy link
Member

Like this? Rufflewind@de6a440

@Rufflewind Rufflewind self-assigned this Jul 14, 2016
@Rufflewind Rufflewind added this to the 1.2.7.0 milestone Jul 14, 2016
@agentm
Copy link
Author

agentm commented Jul 15, 2016

Thanks! That's spot on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: a-feature-request This is a request for a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants