Add support for heap profiling events #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 14, 2017 06:24
See 062feee4e7408ad5b9d882e5fed2c700e337db72 in the GHC repo.
See a9bc54766ddd1bdb011f1656ad58fb409055d08f in the GHC repo.
|
Does anyone volunteer to review this? |
|
It's been a week. I think I'll just merge this if there are no objections. |
|
Took a brief look, no objections from me. |
|
Thanks! I'll merge this and release v0.7.0 when I have time today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds support for the new heap profiling events support in eventlog.
There are some points that are worth mentioning:
EventLogFormat.his updated. As in Use EventLogFormat.h from upstream (GHC) #27, we don't use the upstream version so I manually applied relevant patches from GHC.Textinstead ofStringfor various text fields in the heap profiling events. Also I switched over the textual serializers from bytestring's builder to text's.heapProfParserslooks a bit different from the other parts of the module because I'm not comfortable with the current format which causes a lot of HLint warnings.. Please let me know if it's better to make it similar.