Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code Actions do not seem to work #85

Closed
alanz opened this issue May 23, 2018 · 1 comment
Closed

code Actions do not seem to work #85

alanz opened this issue May 23, 2018 · 1 comment

Comments

@alanz
Copy link
Collaborator

alanz commented May 23, 2018

Opening a file with

foo = id 3

Presents a code action to Evaluate: found id 3, why not 3.

Clicking on the lighbulb and then the presented action does nothing.

Note: The corresponding hint is applied correctly in emacs using emacs-lsp, so I am pretty sure it is a client-side problem.

cc @bubba

@alanz
Copy link
Collaborator Author

alanz commented May 24, 2018

Empirically, the current vscode (as used by master here) does not actually send an executeCommand request to apply a hlint hint unless it has first been registered with the client. Even though the UI presents the command, and allows it to be clicked on.

This means that the following commit needs to be reverted in hie: haskell/haskell-ide-engine@386e521, and hence causes #65 to re-appear.

It seems the codeAction machinery is receiving attention at the moment in vscode, via microsoft/language-server-protocol#389

So perhaps we should wait for the dust to settle shortly and see what results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant