Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multi-line string in var.json #94

Closed
felipecrs opened this issue Jan 4, 2022 · 10 comments · Fixed by #104
Closed

Allow multi-line string in var.json #94

felipecrs opened this issue Jan 4, 2022 · 10 comments · Fixed by #104
Labels
no-stale This issue or PR is exempted from the stable bot.

Comments

@felipecrs
Copy link
Contributor

Problem/Motivation

This was the goal, so that users could set something like:

# Add-on configuration.yaml

additional_sip_config: |
  [my-custom]
  config = yes

Expected behavior

bashio::var.json \
    auto_add "^$(bashio::config 'auto_add')" \
    persons "^${persons}" \
    additional_config "$(bashio::config 'additional_sip_config')" 

To produce a valid JSON with properly escaped line breaks and so.

Actual behavior

2022/01/04 18:28:46 invalid character '\n' in string literal

Steps to reproduce

I think the command above should be enough to replicate the issue.

Proposed changes

None yet.

@felipecrs
Copy link
Contributor Author

A bit off-topic, but it would be nice if the add-on configuration UI could support multiline strings too.

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Feb 4, 2022
@felipecrs
Copy link
Contributor Author

I'll try to take a look at this.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Feb 5, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Mar 7, 2022
@felipecrs
Copy link
Contributor Author

Proposed a fix at #104

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Mar 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Apr 7, 2022
@felipecrs
Copy link
Contributor Author

felipecrs commented Apr 7, 2022

It's not fixed yet, #104 just requires a review.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Apr 8, 2022
@github-actions
Copy link

github-actions bot commented May 8, 2022

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label May 8, 2022
@felipecrs
Copy link
Contributor Author

Still valid.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label May 9, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jun 8, 2022
@frenck frenck reopened this Jun 15, 2022
@frenck frenck added no-stale This issue or PR is exempted from the stable bot. stale There has not been activity on this issue or PR for quite some time. and removed stale There has not been activity on this issue or PR for quite some time. labels Jun 15, 2022
@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jun 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-stale This issue or PR is exempted from the stable bot.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants