Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode where this can not fail horribly when PUSHGATEWAY is not set / is unreachable #1

Open
aelkiss opened this issue Oct 24, 2024 · 0 comments

Comments

@aelkiss
Copy link
Member

aelkiss commented Oct 24, 2024

In development, it's useful to be able to run things that use this module but without having a pushgateway available. We should allow that, perhaps just if PUSHGATEWAY is not set, or perhaps if some other env var like NO_PUSHGATEWAY is set. See https://github.com/hathitrust/feed_internal/pull/78/files#diff-e0477c604dc9ef0eafe909684fc6c7edb2180d9bd85c70c595b5adf82ed9d45aR658-R678 for an example of a mocked progress tracker.

Once this is available we should update any dependencies of ProgressTracker (post-zephir processing, ingest, ...?) to use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant