Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling mistake "Feeback" #48

Closed
hauke96 opened this issue Sep 6, 2021 · 10 comments
Closed

Spelling mistake "Feeback" #48

hauke96 opened this issue Sep 6, 2021 · 10 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@hauke96
Copy link
Owner

hauke96 commented Sep 6, 2021

The feedback-button in the settings screen has a little spelling mistake.

@hauke96 hauke96 added bug Something isn't working good first issue Good for newcomers labels Sep 6, 2021
@PuneetDabral
Copy link
Contributor

sir can i contribute ?

@hauke96
Copy link
Owner Author

hauke96 commented Sep 6, 2021

Sure, feel free to create a pull-request :)

@PuneetDabral
Copy link
Contributor

actually sir i am new in open source can you please help me what i can do .....so i can motivate my self

@hauke96
Copy link
Owner Author

hauke96 commented Sep 7, 2021

I think the best is that you get familiar with pull requests (s. here). To fix this issue, only the button text must be changed, that's is. So if your pull request it's more than one line of code long, you probably did something wrong ;)

@PuneetDabral
Copy link
Contributor

PuneetDabral commented Sep 7, 2021

can you please define the step!!

@hauke96
Copy link
Owner Author

hauke96 commented Sep 7, 2021

I don't know what you mean with "step" but the overall process of pull requests is too much content to an issue. Generally you need to fork the project, clone the repo, make your changes, of course upload/push them and then create a pull request. This is a very basic procedure so there're tons of resources and videos online ;)

@PuneetDabral
Copy link
Contributor

ok sir i will do it....

@PuneetDabral
Copy link
Contributor

sir can i push it on the main branch or any other branch

@hauke96
Copy link
Owner Author

hauke96 commented Sep 7, 2021

That doesn't matter.

@PuneetDabral
Copy link
Contributor

ok sir check it i will create a pull req ...

@hauke96 hauke96 closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants