Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "critical" in TS typings #270

Open
BBosman opened this issue Jun 17, 2024 · 0 comments
Open

Add missing "critical" in TS typings #270

BBosman opened this issue Jun 17, 2024 · 0 comments

Comments

@BBosman
Copy link

BBosman commented Jun 17, 2024

Bug Report

Add missing "critical" in TS typings

Expected Behaviour

const push = PushNotification.init({
  ios: {
    critical: true
  }
});

The above code should compile when used in a TS project.

Actual Behaviour

TS compiler complains about critical not being a valid option at that location.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

See "Expected Behaviour" above.

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

n/a

(Android) Device Vendor (e.g. Samsung, HTC, Sony...)

n/a

cordova info Printout

Cordova Packages:

cli: 12.0.0
    common: 5.0.0
    create: 5.0.0
    lib: 12.0.1
        common: 5.0.0
        fetch: 4.0.0
        serve: 4.0.1

Project Installed Platforms:

ios: 6.3.0

Project Installed Plugins:

@havesource/cordova-plugin-push: 4.0.0

Environment:

OS: macOS Sonoma 14.4.1 (23E224) (darwin 23.4.0) arm64
Node: v16.20.2
npm: 8.19.4

ios Environment:

xcodebuild:

Xcode 15.4
Build version 15F31d

Project Setting Files:

config.xml:
Test Test Test Test
package.json:

--- Start of Cordova JSON Snippet ---
{
"plugins": {
"@havesource/cordova-plugin-push": {}
},
"platforms": [
"ios"
]
}
--- End of Cordova JSON Snippet ---

Sample Push Data Payload

n/a

Sample Code that illustrates the problem

See "Expected Behaviour" above.

Logs taken while reproducing problem

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant