Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve magic numbers to const function approach when we can #41

Open
day01 opened this issue Jul 31, 2024 · 0 comments
Open

resolve magic numbers to const function approach when we can #41

day01 opened this issue Jul 31, 2024 · 0 comments

Comments

@day01
Copy link
Collaborator

day01 commented Jul 31, 2024 •
edited
Loading

Currently, our codebase uses constants to store pre-calculated values such as 2 * pi.

We would like to replace these constants with const fn functions to enable dynamic calculation of values at compile time.

blocked by rust-lang/rust#57241
Unfortunately, the current limitations in Rust do not fully support the use of const fn for f64.
@day01 day01 added this to the version 0.30 milestone Jul 31, 2024
@day01 day01 self-assigned this Jul 31, 2024
@day01 day01 removed this from the version 0.30 milestone Jul 31, 2024
@day01 day01 removed their assignment Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@day01