Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hazelcast docker image versions in integration code samples are not updated #301

Open
kwart opened this issue Feb 22, 2019 · 2 comments
Open
Labels

Comments

@kwart
Copy link
Contributor

kwart commented Feb 22, 2019

$ git grep hazelcast/hazelcast: 
hazelcast-integration/kubernetes/hazelcast.yaml:        image: hazelcast/hazelcast:3.10.3
hazelcast-integration/openshift/hazelcast-cluster/hazelcast-openshift-origin/hazelcast.yaml:  value: hazelcast/hazelcast:3.11

$ git grep hazelcast/hazelcast-enterprise:
hazelcast-integration/kubernetes/hazelcast-enterprise.yaml:        image: hazelcast/hazelcast-enterprise:3.10.3
hazelcast-integration/openshift/hazelcast-cluster/hazelcast-enterprise-openshift-centos/hazelcast.yaml:  value: hazelcast/hazelcast-enterprise:3.11

Could we come up with some improvement to avoid hardcoded versions (e.g. document providing as a parameter), or use some automation to update the version during release? (CC @leszko)

@kwart kwart added the bug label Feb 22, 2019
@leszko
Copy link

leszko commented Feb 22, 2019

@kwart , yeah it would nice it we could automate it. However, I think we would need to write some tests for the code samples (which may not be that easy). In other words, now you have an old version, but you're sure it works correctly, which is not that bad. The worst we could do is to update the version, but not check if it still works.

I'm not sure the bug is the right label, I'd mark it rather as "Enhancement".

@kwart
Copy link
Contributor Author

kwart commented Feb 22, 2019

I understand and I also don't like if anything breaks with a new version, but the code samples are released for specific version so users will not expect they work with an outdated ones.

Missing tests to verify the code works as expected with new Hazelcast versions is a common problem of majority of the samples. We really should resolve it somehow - either include tests here in the repo or have a separate testsuite. (CC @Holmistr )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants