Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tomcat-core artifacts missing from Maven Central #36

Closed
bkoehm opened this issue Dec 8, 2017 · 9 comments · Fixed by #82
Closed

tomcat-core artifacts missing from Maven Central #36

bkoehm opened this issue Dec 8, 2017 · 9 comments · Fixed by #82

Comments

@bkoehm
Copy link

bkoehm commented Dec 8, 2017

http://central.maven.org/maven2/com/hazelcast/hazelcast-tomcat-sessionmanager/1.1.2/ is present, but the tomcat-core dependencies are missing in central.maven.org.

@mesutcelik
Copy link
Contributor

Hi @bkoehm ,
We do create uberJar including tomcat-core so those jars would work fine. Have you had any issue?

@mesutcelik
Copy link
Contributor

closing this one. please send your further questions to https://groups.google.com/forum/#!forum/hazelcast

@anton-johansson
Copy link

anton-johansson commented Jun 18, 2018

Is the uberJar available from Maven Central? One could think that this is the uberJar for Tomcat 8, but it is not. It also has a dependency (tomcat-core) which does not exist, which can cause some really unnecessary headache for users (us). I believe this is the same issue that @bkoehm had. Why is the broken artifact deployed to Maven? And how can I find the uberJar in Maven Central?

EDIT: Only snapshots seems to be deployed for tomcat-core (see here).

@emre-aydin
Copy link
Contributor

emre-aydin commented Jun 18, 2018

Hi @anton-johansson

The artifact is not broken. This is not an uberJar. As you've said, it has a dependency on tomcat-core. Since the JARs are to be put under Tomcat directory manually, we mostly focused on putting it under GitHub releases tab. You can download tomcat-core from the GitHub releases tab (https://github.com/hazelcast/hazelcast-tomcat-sessionmanager/releases).

I agree with making it more user friendly for people using it via Maven though, so I'm reopening the issue. I believe it will be a simple fix to deploy tomcat-core artifact to Maven central. We might also consider having all versions of the JARs as uber JARs which would further simplify deployment, both manual and via Maven.

@anton-johansson
Copy link

anton-johansson commented Jun 18, 2018 via email

@emre-aydin
Copy link
Contributor

@anton-johansson I think I understand the cause of confusion better now. The artifact is indeed an uber JAR but its pom.xml is incorrect as it lists tomcat-core as one of its dependencies. So the JAR is OK, but the pom.xml is incorrect.

@anton-johansson
Copy link

Allright. Since you can't overwrite artifacts in Central, I assume we'll wait for the next release. :)

An alternative would be to deploy empty tomcat-core artifacts, one for each "broken" version.

@emre-aydin
Copy link
Contributor

@mesutcelik suggested that you might try excluding the tomcat-core dependency from hazelcast-tomcat-session-manager dep. in your pom.xml until then.

@anton-johansson
Copy link

Ahh, of course, that should work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants