Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive logging on info level #43

Closed
bergander opened this issue Apr 24, 2018 · 2 comments
Closed

Excessive logging on info level #43

bergander opened this issue Apr 24, 2018 · 2 comments
Milestone

Comments

@bergander
Copy link
Contributor

Tomcat uses info as default logging level. And in HazelcastSessionManager there are a couple of messages which should be on debug level, especially in the findSession method which is heavily used.

I propose to switch those log messages to debug level. Otherwise everyone needs to suppress them in the tomcat config. It's no good for performance to log messages on each request and several thousands of messages when doing a failover on a system with a lot of sessions, especially since the tomcat logging framework (juli) actually creates a stacktrace for each logged message (see log-method in DirectJDKLog).

@bergander
Copy link
Contributor Author

@emre-aydin Thanks for the quick merge!

I missed one of the info-log messages so I created a new pull request for that one: #45

@emre-aydin
Copy link
Contributor

Handled by #44 and #45

@mesutcelik mesutcelik modified the milestones: 1.1.4, 1.2 Apr 27, 2018
@alparslanavci alparslanavci modified the milestones: 1.2, 1.1.4 Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants