Added support for all serialization methods in Hazelcast #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesutcelik
approved these changes
Nov 11, 2019
| @@ -45,7 +45,7 @@ The latest tested versions are **6.0.39**, **7.0.40** and **8.0.36**. | |||
| ***Requirements*** | |||
|
|
|||
| - Tomcat instance must be running with Java 1.6 or higher. | |||
| - Session objects that need to be clustered have to be Serializable. | |||
| - Session objects that need to be clustered have to be serializable on Hazelcast cluster. Please see <a href="https://docs.hazelcast.org/docs/latest/manual/html-single/#serialization" target="_blank">here</a> for how you can configure and implement serialization for Hazelcast. | |||
There was a problem hiding this comment.
just a minor comment. Can the link provided here be broken over time? cc: @Serdaro
There was a problem hiding this comment.
I guess it is mostly ok to use, since it redirects to the latest version.
| objectDataOutput.writeObject(entryObject.getKey()); | ||
| objectDataOutput.writeObject(entryObject.getValue()); | ||
| } catch (Exception e) { | ||
| LOG.warn("Unable to serialize object in session", e); |
There was a problem hiding this comment.
is this a warning or more severe?
There was a problem hiding this comment.
It was also a warning when deserialising, I kept it the same for the serialisation exceptions. We can create an issue, if you think we should increase the severity level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38.