Fixed concurrency issue when finding sessions #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leszko
reviewed
Nov 12, 2020
| @@ -201,7 +201,13 @@ public Session findSession(String id) { | |||
| + "Some failover occurred so reading session from Hazelcast map: " + getMapName()); | |||
| } | |||
|
|
|||
| HazelcastSession hazelcastSession = sessionMap.get(id); | |||
| HazelcastSession hazelcastSession; | |||
| sessionMap.lock(id); | |||
There was a problem hiding this comment.
Is there any significant performance implication of this change?
There was a problem hiding this comment.
It is difficult to say, but I don't think it will affect that much since only the session removal/update is done within the same synchronised block. This is not a good solution, however we cannot use EntryProcessors or MapInterceptors to handle invalidation.
enozcan
approved these changes
Nov 12, 2020
|
@enozcan it might be good to have a benchmark for all session replication options, wdyt? |
|
Sure! I'm curious about the results especially per module basis for particular scenarios. |
leszko
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84.