From 4f843f054107b8106ad8613e315fa8d6b75203bf Mon Sep 17 00:00:00 2001 From: hazuki Date: Mon, 15 Feb 2021 19:59:12 +0900 Subject: [PATCH] Fix downloads confirm messages #160 No.4 --- languages/src/main/res/values-ja/strings.xml | 2 + languages/src/main/res/values/strings.xml | 2 + .../ui/fragment/DownloadListFragment.kt | 60 +++++++++---------- 3 files changed, 34 insertions(+), 30 deletions(-) diff --git a/languages/src/main/res/values-ja/strings.xml b/languages/src/main/res/values-ja/strings.xml index b84cbf61..06b09e95 100644 --- a/languages/src/main/res/values-ja/strings.xml +++ b/languages/src/main/res/values-ja/strings.xml @@ -34,6 +34,8 @@ 表示中の履歴を全て削除しますか? ファビコンを全て削除しますか? このブックマークを削除しますか? + このファイルをデバイスから削除しますか? + このファイルをリストから削除しますか? このボタンを削除しますか? このスピードダイアルを削除しますか? このジェスチャーを削除しますか? diff --git a/languages/src/main/res/values/strings.xml b/languages/src/main/res/values/strings.xml index 96044283..0382183c 100644 --- a/languages/src/main/res/values/strings.xml +++ b/languages/src/main/res/values/strings.xml @@ -35,6 +35,8 @@ Delete all displayed items? Delete all favicon? Delete this bookmark? + Delete this file from device? + Delete this file from list? Delete this button? Delete this speed dial? Delete this gesture? diff --git a/module/download/src/main/java/jp/hazuki/yuzubrowser/download/ui/fragment/DownloadListFragment.kt b/module/download/src/main/java/jp/hazuki/yuzubrowser/download/ui/fragment/DownloadListFragment.kt index e2128d18..7291e158 100644 --- a/module/download/src/main/java/jp/hazuki/yuzubrowser/download/ui/fragment/DownloadListFragment.kt +++ b/module/download/src/main/java/jp/hazuki/yuzubrowser/download/ui/fragment/DownloadListFragment.kt @@ -208,44 +208,44 @@ class DownloadListFragment : Fragment(), ActivityClient.ActivityClientListener, return when (item.itemId) { R.id.delete -> { AlertDialog.Builder(activity) - .setTitle(R.string.confirm) - .setMessage(R.string.confirm_delete_bookmark) - .setPositiveButton(android.R.string.ok) { _, _ -> - val roots = ArrayMap>() - val selectedItems = adapter.getSelectedItems() - selectedItems.forEach { - var items = roots[it.root.uri.toString()] - if (items == null) { - val files = it.root.listFiles() - items = HashMap(files.size) - files.forEach { file -> file.name?.also { name -> items[name] = file } } - roots[it.root.uri.toString()] = items - } - items[it.name]?.delete() + .setTitle(R.string.confirm) + .setMessage(R.string.confirm_delete_download) + .setPositiveButton(android.R.string.ok) { _, _ -> + val roots = ArrayMap>() + val selectedItems = adapter.getSelectedItems() + selectedItems.forEach { + var items = roots[it.root.uri.toString()] + if (items == null) { + val files = it.root.listFiles() + items = HashMap(files.size) + files.forEach { file -> file.name?.also { name -> items[name] = file } } + roots[it.root.uri.toString()] = items } - database.delete(selectedItems) - adapter.reload() + items[it.name]?.delete() + } + database.delete(selectedItems) + adapter.reload() - adapter.notifyDataSetChanged() + adapter.notifyDataSetChanged() - mode.finish() - } - .setNegativeButton(android.R.string.cancel, null) - .show() + mode.finish() + } + .setNegativeButton(android.R.string.cancel, null) + .show() true } R.id.deleteFromList -> { AlertDialog.Builder(activity) - .setTitle(R.string.confirm) - .setMessage(R.string.confirm_delete_bookmark) - .setPositiveButton(android.R.string.ok) { _, _ -> - database.delete(adapter.getSelectedItems()) - adapter.reload() + .setTitle(R.string.confirm) + .setMessage(R.string.confirm_delete_download_list) + .setPositiveButton(android.R.string.ok) { _, _ -> + database.delete(adapter.getSelectedItems()) + adapter.reload() - mode.finish() - } - .setNegativeButton(android.R.string.cancel, null) - .show() + mode.finish() + } + .setNegativeButton(android.R.string.cancel, null) + .show() true }