Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6 toolbar background color issue #187

Closed
ksuuk opened this issue Feb 14, 2021 · 5 comments
Closed

v6 toolbar background color issue #187

ksuuk opened this issue Feb 14, 2021 · 5 comments
Labels

Comments

@ksuuk
Copy link

ksuuk commented Feb 14, 2021

Since v6, the bottom toolbar -s dark background is white and the buttons are invisible, however when I open settings menu, then there the toolbar -s background is dark again, so theme is correct:

Screenshots added.
Screenshot 2021-02-15 at 09 59 31

Screenshot 2021-02-15 at 09 59 17

@hazuki0x0
Copy link
Owner

What is your device and android version?

@ksuuk
Copy link
Author

ksuuk commented Feb 14, 2021

What is your device and android version?

Xperia X, stock Oreo 8.0.

BTW, is this normal, that after v5 > v6 upgrade, Yuzu didn't use find custom theme and used default theme and user must import and select custom theme again?

@hazuki0x0
Copy link
Owner

BTW, is this normal, that after v5 > v6 upgrade, Yuzu didn't use find custom theme and used default theme and user must import and select custom theme again?

Yes, you need to import custom theme due to scoped storage limitations (android 10 or higher). Of course it doesn't affect older versions of android, but I changed it for consistency.

@hazuki0x0 hazuki0x0 added the bug label Feb 14, 2021
@ksuuk
Copy link
Author

ksuuk commented Feb 15, 2021

@hazuki0x0

Tested more, made new, dark based custom theme, copied all settings/colors from old light to the new dark theme. When I compared old and new theme settings (to find out what causes the toolbar background color issue) turned out, that settings are now identical:

{
"lightTheme": "true",
"showTabDivider": "true",
"pullToRefreshDark": "true",
"toolbarBackgroundColor": "0xffffffff",
"toolbarTextColor": "0xff080808",
"toolbarImageColor": "0xff3069c4",
"qcItemBackgroundColorNormal": "0xf4c57373",
"qcItemBackgroundColorSelect": "0xffef8881",
"statusBarDarkIcon": "true"
}

But Yuzu is showing them differently and also Yuzu Browser Theme Creator -s theme preview doesn't match the Yuzu layout. Also when I import theme folder, Yuzu crashes.

Screenshot 2021-02-15 at 08 57 42
Screenshot 2021-02-15 at 09 10 36

So seems that browser and editor are not compatible and Yuzu ignores some custom theme settings.

When I select built in light theme, the toolbar is grey:

Screenshot 2021-02-15 at 09 07 22

And after using built in light or dark theme and then selecting custom theme, Yuzu crashes and looses all browser settings and uses default layout:

Screenshot 2021-02-15 at 09 06 06

@hazuki0x0
Copy link
Owner

Thanks for the detailed debugging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants