Use std optional when use C++ 17 or above #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To pass the CI tests, librime may need to merge rime/librime#738 first. |
WhiredPlanck
added a commit
to WhiredPlanck/librime
that referenced
this pull request
Oct 23, 2023
|
No. The PR doesn't address the root cause of CI error. |
|
Now with the latest commit, rime/librime#738 should pass. |
WhiredPlanck
force-pushed
the
optional
branch
from
e180a8f
to
c0ffe48
Compare
WhiredPlanck
added a commit
to WhiredPlanck/librime
that referenced
this pull request
Oct 23, 2023
|
@hchunhui Thanks for the fix. I'm too newbie to find the cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.