build: Add CMake-based build system (5 of N) #13
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| # Copyright (c) 2023 The Bitcoin Core developers | ||
| # Distributed under the MIT software license, see the accompanying | ||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
|
||
| if(NOT MSVC) | ||
| include(CrossPkgConfig) | ||
| cross_pkg_check_modules(PC_MiniUPnPc QUIET miniupnpc) | ||
| endif() | ||
|
|
||
| find_path(MiniUPnPc_INCLUDE_DIR | ||
| NAMES miniupnpc/miniupnpc.h | ||
| PATHS ${PC_MiniUPnPc_INCLUDE_DIRS} | ||
| ) | ||
|
|
||
| if(MiniUPnPc_INCLUDE_DIR) | ||
| file( | ||
| STRINGS "${MiniUPnPc_INCLUDE_DIR}/miniupnpc/miniupnpc.h" version_strings | ||
| REGEX "^#define[\t ]+MINIUPNPC_API_VERSION[\t ]+[0-9]+" | ||
| ) | ||
| string(REGEX REPLACE "^#define[\t ]+MINIUPNPC_API_VERSION[\t ]+([0-9]+)" "\\1" MiniUPnPc_API_VERSION "${version_strings}") | ||
|
|
||
| # The minimum supported miniUPnPc API version is set to 17. This excludes | ||
| # versions with known vulnerabilities. | ||
| if(MiniUPnPc_API_VERSION GREATER_EQUAL 17) | ||
| set(MiniUPnPc_API_VERSION_OK TRUE) | ||
| endif() | ||
| endif() | ||
|
|
||
| if(MSVC) | ||
| cmake_path(GET MiniUPnPc_INCLUDE_DIR PARENT_PATH MiniUPnPc_IMPORTED_PATH) | ||
| find_library(MiniUPnPc_LIBRARY_DEBUG | ||
| NAMES miniupnpc PATHS ${MiniUPnPc_IMPORTED_PATH}/debug/lib | ||
| NO_DEFAULT_PATH | ||
| ) | ||
| find_library(MiniUPnPc_LIBRARY_RELEASE | ||
| NAMES miniupnpc PATHS ${MiniUPnPc_IMPORTED_PATH}/lib | ||
| NO_DEFAULT_PATH | ||
| ) | ||
| set(MiniUPnPc_required MiniUPnPc_IMPORTED_PATH) | ||
| else() | ||
| find_library(MiniUPnPc_LIBRARY | ||
| NAMES miniupnpc | ||
| PATHS ${PC_MiniUPnPc_LIBRARY_DIRS} | ||
| ) | ||
| set(MiniUPnPc_required MiniUPnPc_LIBRARY) | ||
| endif() | ||
|
|
||
| include(FindPackageHandleStandardArgs) | ||
| find_package_handle_standard_args(MiniUPnPc | ||
| REQUIRED_VARS ${MiniUPnPc_required} MiniUPnPc_INCLUDE_DIR MiniUPnPc_API_VERSION_OK | ||
| ) | ||
|
|
||
| if(MiniUPnPc_FOUND AND NOT TARGET MiniUPnPc::MiniUPnPc) | ||
| add_library(MiniUPnPc::MiniUPnPc UNKNOWN IMPORTED) | ||
| set_target_properties(MiniUPnPc::MiniUPnPc PROPERTIES | ||
| INTERFACE_INCLUDE_DIRECTORIES "${MiniUPnPc_INCLUDE_DIR}" | ||
| ) | ||
| if(MSVC) | ||
| if(MiniUPnPc_LIBRARY_DEBUG) | ||
| set_property(TARGET MiniUPnPc::MiniUPnPc APPEND PROPERTY IMPORTED_CONFIGURATIONS DEBUG) | ||
| set_target_properties(MiniUPnPc::MiniUPnPc PROPERTIES | ||
| IMPORTED_LOCATION_DEBUG "${MiniUPnPc_LIBRARY_DEBUG}" | ||
| ) | ||
| endif() | ||
| if(MiniUPnPc_LIBRARY_RELEASE) | ||
| set_property(TARGET MiniUPnPc::MiniUPnPc APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE) | ||
| set_target_properties(MiniUPnPc::MiniUPnPc PROPERTIES | ||
| IMPORTED_LOCATION_RELEASE "${MiniUPnPc_LIBRARY_RELEASE}" | ||
| ) | ||
| endif() | ||
| else() | ||
| set_target_properties(MiniUPnPc::MiniUPnPc PROPERTIES | ||
| IMPORTED_LOCATION "${MiniUPnPc_LIBRARY}" | ||
| ) | ||
| endif() | ||
| set_property(TARGET MiniUPnPc::MiniUPnPc PROPERTY | ||
| INTERFACE_COMPILE_DEFINITIONS USE_UPNP=1 $<$<PLATFORM_ID:Windows>:MINIUPNP_STATICLIB> | ||
| ) | ||
| endif() | ||
|
|
||
| mark_as_advanced( | ||
| MiniUPnPc_INCLUDE_DIR | ||
| MiniUPnPc_LIBRARY | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Copyright (c) 2023 The Bitcoin Core developers | ||
| # Distributed under the MIT software license, see the accompanying | ||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
|
||
| find_path(NATPMP_INCLUDE_DIR | ||
| NAMES natpmp.h | ||
| ) | ||
|
|
||
| find_library(NATPMP_LIBRARY | ||
| NAMES natpmp | ||
| ) | ||
|
|
||
| include(FindPackageHandleStandardArgs) | ||
| find_package_handle_standard_args(NATPMP | ||
| REQUIRED_VARS NATPMP_LIBRARY NATPMP_INCLUDE_DIR | ||
| ) | ||
|
|
||
| if(NATPMP_FOUND AND NOT TARGET NATPMP::NATPMP) | ||
| add_library(NATPMP::NATPMP UNKNOWN IMPORTED) | ||
| set_target_properties(NATPMP::NATPMP PROPERTIES | ||
| IMPORTED_LOCATION "${NATPMP_LIBRARY}" | ||
| INTERFACE_INCLUDE_DIRECTORIES "${NATPMP_INCLUDE_DIR}" | ||
| ) | ||
| set_property(TARGET NATPMP::NATPMP PROPERTY | ||
| INTERFACE_COMPILE_DEFINITIONS USE_NATPMP=1 $<$<PLATFORM_ID:Windows>:NATPMP_STATICLIB> | ||
| ) | ||
| endif() | ||
|
|
||
| mark_as_advanced( | ||
| NATPMP_INCLUDE_DIR | ||
| NATPMP_LIBRARY | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Copyright (c) 2023 The Bitcoin Core developers | ||
| # Distributed under the MIT software license, see the accompanying | ||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
|
||
| # A tri-state option with three possible values: AUTO, OFF and ON (case-insensitive). | ||
| # TODO: This function will be removed before merging into master. | ||
| function(tristate_option variable description_text auto_means_on_condition_text default_value) | ||
| set(${variable} ${default_value} CACHE STRING | ||
| "${description_text} \"AUTO\" means \"ON\" ${auto_means_on_condition_text}" | ||
| ) | ||
|
|
||
| set(expected_values AUTO OFF ON) | ||
| set_property(CACHE ${variable} PROPERTY STRINGS ${expected_values}) | ||
|
|
||
| string(TOUPPER "${${variable}}" value) | ||
| if(NOT value IN_LIST expected_values) | ||
| message(FATAL_ERROR "${variable} value is \"${${variable}}\", but must be one of \"AUTO\", \"OFF\" or \"ON\".") | ||
| endif() | ||
|
|
||
| set(${${variable}} ${value} PARENT_SCOPE) | ||
| endfunction() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| # Copyright (c) 2023 The Bitcoin Core developers | ||
| # Distributed under the MIT software license, see the accompanying | ||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
|
||
| # Optional features and packages. | ||
|
|
||
| if(CCACHE) | ||
| find_program(CCACHE_EXECUTABLE ccache) | ||
| if(CCACHE_EXECUTABLE) | ||
| set(CCACHE ON) | ||
| if(MSVC) | ||
| # See https://github.com/ccache/ccache/wiki/MS-Visual-Studio | ||
| set(MSVC_CCACHE_WRAPPER_CONTENT "\"${CCACHE_EXECUTABLE}\" \"${CMAKE_CXX_COMPILER}\"") | ||
| set(MSVC_CCACHE_WRAPPER_FILENAME wrapped-cl.bat) | ||
| file(WRITE ${CMAKE_BINARY_DIR}/${MSVC_CCACHE_WRAPPER_FILENAME} "${MSVC_CCACHE_WRAPPER_CONTENT} %*") | ||
| set(CMAKE_VS_GLOBALS | ||
| "CLToolExe=${MSVC_CCACHE_WRAPPER_FILENAME}" | ||
| "CLToolPath=${CMAKE_BINARY_DIR}" | ||
| "TrackFileAccess=false" | ||
| "UseMultiToolTask=true" | ||
| "DebugInformationFormat=OldStyle" | ||
| ) | ||
|
Comment on lines
+11
to
+22
There was a problem hiding this comment. Apparently, this code does not work with cache 4.8 ( Going to investigate the issue, but I'm really hoping this won't be a blocker for this PR. There was a problem hiding this comment. ccache 4.8 is broken, ccache 4.7.4, 4.7.5 work fine. There was a problem hiding this comment. Following https://github.com/ccache/ccache/wiki/MS-Visual-Studio literally for the simplest source code like "int main { return 0; }" works for 4.7, but 4.8 reports zero of "cacheable calls". For example, https://cirrus-ci.com/task/6670364843966464. There was a problem hiding this comment.
ccache/ccache#1262 is somewhat related. |
||
| else() | ||
| list(APPEND CMAKE_C_COMPILER_LAUNCHER ${CCACHE_EXECUTABLE}) | ||
| list(APPEND CMAKE_CXX_COMPILER_LAUNCHER ${CCACHE_EXECUTABLE}) | ||
| endif() | ||
| elseif(CCACHE STREQUAL "AUTO") | ||
| set(CCACHE OFF) | ||
| else() | ||
| message(FATAL_ERROR "ccache requested, but not found.") | ||
| endif() | ||
| mark_as_advanced(CCACHE_EXECUTABLE) | ||
| endif() | ||
|
|
||
| if(WITH_NATPMP) | ||
| find_package(NATPMP MODULE) | ||
| if(NATPMP_FOUND) | ||
| set(WITH_NATPMP ON) | ||
| elseif(WITH_NATPMP STREQUAL "AUTO") | ||
| message(WARNING "libnatpmp not found, disabling.\n" | ||
| "To skip libnatpmp check, use \"-DWITH_NATPMP=OFF\".\n") | ||
| set(WITH_NATPMP OFF) | ||
| else() | ||
| message(FATAL_ERROR "libnatpmp requested, but not found.") | ||
| endif() | ||
| endif() | ||
|
|
||
| if(WITH_MINIUPNPC) | ||
| find_package(MiniUPnPc MODULE) | ||
| if(MiniUPnPc_FOUND) | ||
| set(WITH_MINIUPNPC ON) | ||
| elseif(WITH_MINIUPNPC STREQUAL "AUTO") | ||
| message(WARNING "libminiupnpc not found, disabling.\n" | ||
| "To skip libminiupnpc check, use \"-DWITH_MINIUPNPC=OFF\".\n") | ||
| set(WITH_MINIUPNPC OFF) | ||
| else() | ||
| message(FATAL_ERROR "libminiupnpc requested, but not found.") | ||
| endif() | ||
| endif() | ||
|
|
||
| if(WITH_ZMQ) | ||
|
There was a problem hiding this comment. zmq started shipping a cmake config file starting with v4.2.2. Once we bump our zmq requirement in the future, we'll be able to use There was a problem hiding this comment.
But not Ubuntu's libzmq3-dev packages, unfortunately. There was a problem hiding this comment. Still, mind adding a note that it's supported upstream and we'll be able to switch at some point in the future? There was a problem hiding this comment.
Sure. I'll add it. |
||
| if(MSVC) | ||
| find_package(ZeroMQ CONFIG) | ||
| else() | ||
| # The ZeroMQ project has provided config files since v4.2.2. | ||
| # TODO: Switch to find_package(ZeroMQ) at some point in the future. | ||
| include(CrossPkgConfig) | ||
| cross_pkg_check_modules(libzmq IMPORTED_TARGET libzmq>=4) | ||
| if(libzmq_FOUND) | ||
| set_property(TARGET PkgConfig::libzmq APPEND PROPERTY | ||
| INTERFACE_COMPILE_DEFINITIONS $<$<PLATFORM_ID:Windows>:ZMQ_STATIC> | ||
| ) | ||
| set_property(TARGET PkgConfig::libzmq APPEND PROPERTY | ||
| INTERFACE_LINK_LIBRARIES $<$<PLATFORM_ID:Windows>:iphlpapi;ws2_32> | ||
| ) | ||
| endif() | ||
| endif() | ||
| if(TARGET libzmq OR TARGET PkgConfig::libzmq) | ||
| set(WITH_ZMQ ON) | ||
| elseif(WITH_ZMQ STREQUAL "AUTO") | ||
| message(WARNING "libzmq not found, disabling.\n" | ||
| "To skip libzmq check, use \"-DWITH_ZMQ=OFF\".\n") | ||
| set(WITH_ZMQ OFF) | ||
| else() | ||
| message(FATAL_ERROR "libzmq requested, but not found.") | ||
| endif() | ||
| endif() | ||
|
|
||
| include(CheckCXXSourceCompiles) | ||
| if(WITH_USDT) | ||
| check_cxx_source_compiles(" | ||
| #include <sys/sdt.h> | ||
|
|
||
| int main() | ||
| { | ||
| DTRACE_PROBE(\"context\", \"event\"); | ||
| } | ||
| " HAVE_USDT_H | ||
| ) | ||
| if(HAVE_USDT_H) | ||
| set(ENABLE_TRACING TRUE) | ||
| set(WITH_USDT ON) | ||
| elseif(WITH_USDT STREQUAL "AUTO") | ||
| set(WITH_USDT OFF) | ||
| else() | ||
| message(FATAL_ERROR "sys/sdt.h requested, but not found.") | ||
| endif() | ||
| endif() | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "opt-in by default" mean? That there will be just two options to choose from (not 3): ON and OFF, that it will be ON by default and (it follows that) if the corresponding library is not found, then it will result in an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It means that basically all features/options will be OFF by default, and builders will have to actively opt-in to what they want. If they opt-in to something, and do not have the required libs/prerequisites, the build will error.