-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is EOY sedra a thing? #74
Comments
This is something that was in the original Hebcal C that i simply ported. I don't exactly know how the calculations work for all of this TBH. @mjradwin or @dsadinoff might know. |
Until they'll have the time to respond, I'm using this: |
Sorry for being rude and pinging again in case you missed the last one. Thanks a ton! |
I agree with @gdoron there is a mistake there. |
Hi,
For
new Hebcal.HDate(19, 7, 5780).getSedra()
I'm getting[ 'End-of-Year: Simchat-Torah, Sukkot' ]
which is a thing I've never heard of.I've asked around, no one knows why this is the Sedra, it just should be regular Shabbat Hol Hamoed.
The weird thing, it's not consistent, for example, for
new Hebcal.HDate(16, 7, 5779).getSedra()
I'm getting[ 'Chol hamoed Sukkot' ]
I've checked the source code, and I see it's by design(?) as it's there explicitly.
Am I missing something or is it a mistake\bug?
Best,
Doron
The text was updated successfully, but these errors were encountered: