[site:install] Exitcode 0 even when some error occurs

[zoiosilva]

Problem/Motivation

The command should return a non-zero value when there is a problem like a php extension missing, or the site is already installed.

Details to include:
If we put the command on a CI pipeline, it is desirable to get a proper error code to avoid false positive situations.

How to reproduce

• Run the site-install command on an already installed drupal site;
• run echo $? to see the error code;
• The proper error code should at least be 1, not 0;

Details to include:

• Console version: 1.8.0.
• Console Launcher version: 1.8.0.

Solution

My suggestion is that we get the return value of the runInstaller in this line:

drupal-console/src/Command/Site/InstallCommand.php

Line 466 in 6af1543

$this->runInstaller($database_install, $uri);

And return it right away if it's not zero.