-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event capturing #614
Merged
Merged
Event capturing #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows widgets to inform the runtime about whether they have handled an event or not.
Specifically, a new
event::Status
enum has been introduced. It has two variants:Ignored
andCaptured
, andWidget::on_event
now must return one of them:Captured
if the event was handled by the implementor.Ignored
otherwise.As a consequence,
UserInterface::update
has been changed to return anevent::Status
for every processedEvent
. This should help users that are integratingiced
with their own custom event loop to implement proper event propagation (see #408 and #455).Furthermore,
subscription::Recipe
iniced_native
now takes a stream of(Event, event::Status)
as input, effectively allowing subscriptions to discard events that have already been processed by a widget. This is specially useful for implementing global hotkeys (e.g. if aTextInput
is focused, hotkeys will not trigger when typing on it).Fixes #408.
Closes #455.