Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time between first review and last approving review #13

Closed
jack-michaud opened this issue Apr 7, 2022 · 0 comments · Fixed by #15
Closed

Add time between first review and last approving review #13

jack-michaud opened this issue Apr 7, 2022 · 0 comments · Fixed by #15

Comments

@jack-michaud
Copy link
Contributor

jack-michaud commented Apr 7, 2022

Great plugin @hectcastro! I'm starting to use this at work to gather some metrics.

An additional metric that would be useful for me and my team is the time between the first non-author review and the last approving review.

- A) PR created
- B) (Author review, with annotations)
* C) Reviewer 1 requests changes
| D) Author writes commits and re-requests
* E) Reviewer 1 approves changes
- F) Merge

The time between C and E is what I'm most concerned with: when this duration is large, this is indicative of an area for improvement (especially when C + D repeat themselves!).

It feels to me like this is one the missing metrics between Lead Time and Time to Merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant