Fix hyphen html comment syntax highlight overflow #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when an html comment like this one is used:
<!---------- Sample Comment ----------->
(no spaces between the hyphens forming the line and those forming the comment delimiter), everything under it will be grayed.I looked at HTML's comments RFC specs to verify if a comment like this is illegal or not, but it seems good to me, so I copied the same value used in language-html to make sure it's consistent, and it fixed the issue.
Also fun fact, Github's syntax highlight also seem to suffer this same problem ! 🤔 🤯 !
Here is an HTML syntax highlight: 👍🏼
and here is a Vue syntax highlight: 👎🏼