Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Off" feedback not sent for virtual control elements under certain conditions #563

Closed
helgoboss opened this issue Apr 14, 2022 · 0 comments
Labels
bug Something isn't working low priority realearn Related to ReaLearn

Comments

@helgoboss
Copy link
Owner

helgoboss commented Apr 14, 2022

When using conditional activation in the controller compartment to switch on/off a mapping with a virtual target, I came across a bug.

  • A real source RS which is used as source in a virtual controller mapping VM1 of a ReaLearn instance R but doesn't have a corresponding main mapping must not be affected by that instance R - in order to let other instances or scripts take control of it. That works!
  • However, one would expect that when deactivating another virtual controller mapping VM2 with the same real source RS (this one has a corresponding main mapping), "off" feedback would be sent to RS. This doesn't happen!
  • The existence of VM1 prevents ReaLearn from switching the mapping "Off". When removing VM1 (or disabling feedback), "off" feedback is sent as expected.

It's low-priority for now because in practice, we mostly have corresponding main mappings in such cases.

Steps to reproduce:

  • Use "APC Key 25 controller preset for Playtime 2" together with "Grid main preset" (with scene buttons unmapped)
  • Press Shift and see how the scene launch buttons don't turn the lights off when Shift released.
@helgoboss helgoboss added bug Something isn't working low priority labels Apr 14, 2022
@helgoboss helgoboss added the realearn Related to ReaLearn label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority realearn Related to ReaLearn
Projects
None yet
Development

No branches or pull requests

1 participant