Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target maximum value can be exceeded in relative mode #577

Closed
valankar opened this issue May 18, 2022 · 5 comments
Closed

Target maximum value can be exceeded in relative mode #577

valankar opened this issue May 18, 2022 · 5 comments
Labels
bug Something isn't working realearn Related to ReaLearn

Comments

@valankar
Copy link

I have setup a relative encoder to set volume for a selected track. I've set the target max to 0 db. However, the actual maximum becomes 0.17 dB. If I set the max to 1 dB, it actually goes to 1.09 dB

Please see the following screen capture:

https://i.imgur.com/wrnAjt4.gif

Have I setup something wrong?

The device I'm using is:

https://intech.studio/shop/modules/en16

and I have set it to relative mode via:

https://intech.studio/support/docs/reference-manual/control-element-functions/encoder#encoder_mode

@helgoboss
Copy link
Owner

Looks like it obeys the maximum but not 100% accurate. Not sure why. Will look into it, approximately in some weeks. Until then you can work around the issue by simply entering a smaller value.

Oh, and I need a test project (no 3rd-party plug-ins).

@valankar
Copy link
Author

Sorry, but entering a smaller value where? In Target Max? I tried putting some value there but I can't figure out what maps to 0 dB. For example, setting target max to -0.15 results in a max value of -0.29.

https://i.imgur.com/91IzWFi.jpg

I've attached an example project.

realearn volume issue.zip

@helgoboss
Copy link
Owner

Yes, I meant in Target Max. Just had a quick look. It only happens with relative control. Seems like it doesn't obey Target Max when doing the last step before reaching the Target Max. If the step size is large, it will just "step over" Target Max.

Workaround is to lower Step Min/Max, but this is obviously not desired in most cases. Or use "Make absolute", but then you lose the advantages of relative control.

So the only real fix - if you need that amount of accuracy - is that I fix it on ReaLearn side. It's a bug.

@helgoboss helgoboss added the bug Something isn't working label May 22, 2022
@helgoboss helgoboss changed the title Target maximum value not obeyed Target maximum value can be exceeded in relative mode May 22, 2022
@helgoboss
Copy link
Owner

This happened because ReaLearn was adjusting the target min/max interval so it's a multiple of the step size. This makes sense for targets with discrete values - in order to not end up on a value in-between its discrete values. It doesn't make sense for continuous targets such as yours (track volume), so I disabled that behaviour for continuous targets. It should now obey target min/max 100% accurate. (in upcoming 2.13.0-pre.5)

@valankar
Copy link
Author

valankar commented Jun 9, 2022

Thanks!

@helgoboss helgoboss added the realearn Related to ReaLearn label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working realearn Related to ReaLearn
Projects
None yet
Development

No branches or pull requests

2 participants