Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mouse target (e.g. for controlling currently hovered parameter) #686

Closed
helgoboss opened this issue Sep 20, 2022 · 4 comments
Closed

Add mouse target (e.g. for controlling currently hovered parameter) #686

helgoboss opened this issue Sep 20, 2022 · 4 comments
Labels
enhancement New feature or request next realearn Related to ReaLearn

Comments

@helgoboss
Copy link
Owner

No description provided.

@helgoboss helgoboss added enhancement New feature or request next labels Sep 20, 2022
@helgoboss helgoboss mentioned this issue Sep 20, 2022
Closed
@helgoboss
Copy link
Owner Author

This is going to be possible, soon. At least with plug-ins that allow mouse wheel control of parameters. Maybe I also get mouse dragging to work, but let's see.

helgoboss added a commit that referenced this issue Sep 21, 2022
@helgoboss
Multiple changes
8d8e358 
- #686 Experiment with a new mouse target
- Fix error when learning and loading some special keyboard keys on macOS
- Improve target control logging to include error
helgoboss added a commit that referenced this issue Sep 21, 2022
@helgoboss
#686 Fix clicking not being reliable because no current value
a1aa2cc
helgoboss added a commit that referenced this issue Sep 21, 2022
@helgoboss
#686 Use possibly more efficient relative mouse cursor movement
6fced35
helgoboss added a commit that referenced this issue Sep 21, 2022
@helgoboss
#686 Add possibility to choose scroll axis, make persistence future-p…
7a447f9 
…roof
helgoboss added a commit that referenced this issue Sep 21, 2022
@helgoboss
#686 Make y the default axis
1cdd6ae
helgoboss added a commit that referenced this issue Sep 21, 2022
@helgoboss
#686 Fix mouse wheel scroll direction
59adad7
helgoboss added a commit that referenced this issue Sep 21, 2022
@helgoboss
#686 Return mouse button state correctly
591a68c
helgoboss added a commit that referenced this issue Sep 21, 2022
@helgoboss
#686 Remove Drag and distinguish between MoveTo and MoveBy instead
5b95286
helgoboss added a commit that referenced this issue Sep 21, 2022
@helgoboss
#686 Remove mouse-rs, just keep enigo
5b2665e
@helgoboss
Copy link
Owner Author

helgoboss commented Sep 21, 2022 •
edited
Loading

Tested on macOS, Windows and Linux (Ubuntu).

Known issues:

  • "Move cursor to/by": Fast repeated invocations can actually result in less distance because the OS doesn't process each movement. Ideas:
    • Don't report the actual mouse position as current value but the last set one.
    • Throttle
  • "Move cursor to/by": Using a high-res fader with "Make relative" seems to do pretty large steps even if invoked very softly.
  • "Turn scroll wheel": Appeared to have a similar issue when turning fast as with moving the cursor. Investigate.
  • macOS: Simulating a drag works on REAPER's faders but not on REAPER's circular controls (but using wheel scroll simulation should be preferred anyway because the mouse cursor doesn't leave its initial position - not all plug-ins make sure the mouse cursor stays at position)
  • macOS: Not having "Accessibility" privilege granted will make ReaLearn panic (device_query crate issue)
  • Windows: When using "Move cursor to" with Y axis, the cursor doesn't stay on the same X coordinate. Better use "Move cursor by" for the time being.

helgoboss added a commit that referenced this issue Sep 21, 2022
@helgoboss
#686 Fix Linux build
a39d7a8
helgoboss added a commit that referenced this issue Oct 3, 2022
@helgoboss
#686 Fix Linux build (egui doesn't work yet though)
bed511d
helgoboss added a commit that referenced this issue Oct 8, 2022
@helgoboss
#686 Update WDL and reaper-rs, remove build warnings on Linux
dad8fb0
@helgoboss helgoboss mentioned this issue Nov 8, 2022
Open
@helgoboss
Copy link
Owner Author

A new issue has been created for the remaining issues. Not that important right now. The basics work quite well so far and users like it.

helgoboss added a commit that referenced this issue Nov 23, 2022
@helgoboss
#686 Improve how mouse target values are displayed in mapping panel
4101309
helgoboss added a commit that referenced this issue Nov 23, 2022
@helgoboss
#686 Avoid relative values to be displayed as discrete target values
a5b03b0
@orivej
Copy link

orivej commented Dec 1, 2022

Thank you for your work!
I have noticed that now (since v2.14.0) the Linux plugin ReaLearn-x64.so has a dynamic dependency on libxdo3: it is not just a build time dependency — end users have to install it too, otherwise Reaper fails to enable the plugin. It seems worth mentioning this in the installation instructions and in the changelog.

@helgoboss helgoboss added the realearn Related to ReaLearn label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request next realearn Related to ReaLearn
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orivej @helgoboss