Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helidon Sitegen Maven Plugin: images folder is not always copied #949

Open
ghillert opened this issue Jun 30, 2023 · 0 comments
Open

Helidon Sitegen Maven Plugin: images folder is not always copied #949

ghillert opened this issue Jun 30, 2023 · 0 comments
Labels
3.x bug Something isn't working sitegen
Milestone

Comments

@ghillert
Copy link

I noticed a weird issue when upgrade the Coherence Spring website to the latest 3.0.5 release of the Helidon Sitegen Maven Plugin. I had a website that was using no images in the Asciidoc directly. Just the logo and favicon, e.g.:

    navigation:
      type: "ROOT"
      title: "Oracle Coherence Spring"
      glyph:
        type: "image"
        value: "images/logo.svg"

See: https://github.com/coherence-community/coherence-spring/blob/main/coherence-spring-site/sitegen.yaml

In that case, the images folder was not copied over to /target/site/ and the logo was not displayed. However, as soon as I added an image to one of the AsciiDoc pages, everything inside the images got copied over and worked as expected.

This works (The only image in my adoc files):

[CARD]
.Quickstart
[image=logo-with-padding.svg,link=refdocs/reference/html/quickstart.html,link-type=url]
--
Chapter of the Reference Guide.
--

This will fail, no images folder copied. Navigation logo missing.

[CARD]
.Quickstart
[icon=power_settings_new,link=refdocs/reference/html/quickstart.html,link-type=url]
--
Chapter of the Reference Guide.
--

See: https://github.com/coherence-community/coherence-spring/blob/main/coherence-spring-site/docs/about/01_overview.adoc?plain=1

@romain-grecourt romain-grecourt added 3.x bug Something isn't working sitegen labels Jul 1, 2023
@romain-grecourt romain-grecourt modified the milestones: 3.0.6, 3.0.7 Jul 1, 2023
@romain-grecourt romain-grecourt modified the milestones: 4.0.0, 4.0.1, 4.0.2 Oct 23, 2023
@romain-grecourt romain-grecourt modified the milestones: 4.0.2, 4.0.3 Nov 15, 2023
@romain-grecourt romain-grecourt modified the milestones: 4.0.3, 4.0.5, 4.0.6 Jan 9, 2024
@romain-grecourt romain-grecourt modified the milestones: 4.0.6, 4.0.7 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x bug Something isn't working sitegen
Projects
None yet
Development

No branches or pull requests

2 participants