:q (quit) command unexpected behaviour (unsaved buffer) with auto-save by delay

[justforcomment]

Summary

When you enable autosave by delay, the :q (quit) command does not work as expected, the editor does not allow you to exit, although the changes have already been made to the disk.

At the same time, changes in .toml (may other also) files or files without extension, it works correctly.

On video the expected behavior is shown first, then the problem described.

auto_save_with_quit.mp4

Reproduction Steps

I tried this:

1. hx

I expected this to happen: write change with auto-save, then just quit

Instead, this happened: occurs warning of unsaved buffer

Helix log

It is unexpected behaviour only.

~/.cache/helix/helix.log

helix.log

Platform

Linux/Devuan

Terminal Emulator

Kitty

Installation Method

source

Helix Version

helix 24.3

[the-mikedavis]

This is ultimately the same as #11024 but it's very easy to trigger with auto-save. For auto-save in particular an easy solution would be to prevent saving while in insert mode. We would need to trigger the auto-save handler on the mode change hook too though to make sure we save after waiting a while between the last edit and switching between insert and normal modes